error: only prepend timestamp on stderr
commit615cf669b55a689f9e535ecf87075e50004b6e0a
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 10 Aug 2015 13:15:41 +0000 (10 14:15 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 18 Sep 2015 12:34:39 +0000 (18 14:34 +0200)
tree6ff8256f4f0293185d0cdc99a8ce79524529f6ee
parent16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d
error: only prepend timestamp on stderr

The -msg timestamp=on option prepends a timestamp to error messages.
This is useful on stderr where it allows users to identify when an error
was raised.

Timestamps do not make sense on the monitor since error_report() is
called in response to a synchronous monitor command and the user already
knows "when" the command was issued.  Additionally, the rest of the
monitor conversation lacks timestamps so the error timestamp cannot be
correlated with other activity.

Only prepend timestamps on stderr.  This fixes libvirt's 'drive_del'
processing, which did not expect a timestamp.  Other QEMU monitor
clients are probably equally confused by timestamps on monitor error
messages.

Cc: Markus Armbruster <armbru@redhat.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Frank Schreuder <fschreuder@transip.nl>
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <1439212541-16997-1-git-send-email-stefanha@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Tested-by: Frank Schreuder <fschreuder@transip.nl>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
util/qemu-error.c