target/riscv: Fix tb->flags FS status
commit613fa160e19abe8e1fe44423fcfa8ec73d3d48e5
authorShihPo Hung <shihpo.hung@sifive.com>
Wed, 15 Jan 2020 06:17:31 +0000 (14 22:17 -0800)
committerPalmer Dabbelt <palmerdabbelt@google.com>
Thu, 16 Jan 2020 18:02:58 +0000 (16 10:02 -0800)
tree2ab0fc22e44548385a5fda5c5f7afaca5b106e93
parenta37f21c27d3e2342c2080aafd4cfe7e949612428
target/riscv: Fix tb->flags FS status

It was found that running libquantum on riscv-linux qemu produced an
incorrect result. After investigation, FP registers are not saved
during context switch due to incorrect mstatus.FS.

In current implementation tb->flags merges all non-disabled state to
dirty. This means the code in mark_fs_dirty in translate.c that
handles initial and clean states is unreachable.

This patch fixes it and is successfully tested with:
  libquantum

Thanks to Richard for pointing out the actual bug.

v3: remove the redundant condition
v2: root cause FS problem

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: ShihPo Hung <shihpo.hung@sifive.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
target/riscv/cpu.h