| commit | 607206948cacda4a80be5b976dba490970a18a76 | |
| author | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | |
| Wed, 7 Apr 2021 19:58:00 +0000 (7 20:58 +0100) | ||
| committer | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | |
| Mon, 12 Apr 2021 21:35:53 +0000 (12 22:35 +0100) | ||
| tree | 632319f6acf459f66a97144a2a41efeb11e7eb77 | treesnapshot (tar.gz zip) |
| parent | 324c8809897c8c53ad05c3a7147d272f1711cd5e | commitdiff |
esp: ensure that do_cmd is set to zero before submitting an ESP select command
When a CDB has been received and is about to be submitted to the SCSI layer
via one of the ESP select commands, ensure that do_cmd is set to zero before
executing the command.
Otherwise a guest executing 2 valid CDBs in quick sequence can invoke the SCSI
.transfer_data callback again before do_cmd is set to zero by the callback
function triggering an assert at the start of esp_transfer_data().
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210407195801.685-12-mark.cave-ayland@ilande.co.uk>
When a CDB has been received and is about to be submitted to the SCSI layer
via one of the ESP select commands, ensure that do_cmd is set to zero before
executing the command.
Otherwise a guest executing 2 valid CDBs in quick sequence can invoke the SCSI
.transfer_data callback again before do_cmd is set to zero by the callback
function triggering an assert at the start of esp_transfer_data().
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210407195801.685-12-mark.cave-ayland@ilande.co.uk>
| hw/scsi/esp.c | diffblobblamehistory |