migration: Recover block devices if failure in device state
commit6039dd5b1c45d76403b9dcadd2afd7efd8f42330
authorDr. David Alan Gilbert <dgilbert@redhat.com>
Mon, 5 Feb 2018 09:13:37 +0000 (5 09:13 +0000)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 6 Feb 2018 14:53:02 +0000 (6 14:53 +0000)
tree4f1fc5dbebe4c03e17be9410ec75473b5cad983e
parent6a7724e9a239b5f1342df00deedab06f3d360083
migration: Recover block devices if failure in device state

In e91d895 I added the new pause-before-switchover mechanism
to allow migration completion to be delayed; this changes the
last state prior to completion to MIGRATE_STATUS_DEVICE rather
than MIGRATE_STATUS_ACTIVE.

Fix the failure path in migration_completion to recover the block
devices if it fails in MIGRATE_STATUS_DEVICE, not just the
MIGRATE_STATUS_ACTIVE that it previously had.

This corresponds to rh bz:
  https://bugzilla.redhat.com/show_bug.cgi?id=1538494
whose symptom is an occasional source crash on a failed migration.

Fixes: e91d8951d59d483f085f
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/migration.c