| commit | 5fe31c25cce3b09e989e40439667cd4961aba969 | |
| author | Kevin Wolf <kwolf@redhat.com> | |
| Mon, 6 Mar 2017 15:20:51 +0000 (6 16:20 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Tue, 7 Mar 2017 13:53:28 +0000 (7 14:53 +0100) | ||
| tree | 0b9809f4e3af0d80e817a65d0723f305dfe187ae | treesnapshot (tar.gz zip) |
| parent | 234ac1a9025bcfcc532449f72a97b3d4754d466c | commitdiff |
block: Fix error handling in bdrv_replace_in_backing_chain()
When adding an Error parameter, bdrv_replace_in_backing_chain() would
become nothing more than a wrapper around change_parent_backing_link().
So make the latter public, renamed as bdrv_replace_node(), and remove
bdrv_replace_in_backing_chain().
Most of the callers just remove a node from the graph that they just
inserted, so they can use &error_abort, but completion of a mirror job
with 'replaces' set can actually fail.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
When adding an Error parameter, bdrv_replace_in_backing_chain() would
become nothing more than a wrapper around change_parent_backing_link().
So make the latter public, renamed as bdrv_replace_node(), and remove
bdrv_replace_in_backing_chain().
Most of the callers just remove a node from the graph that they just
inserted, so they can use &error_abort, but completion of a mirror job
with 'replaces' set can actually fail.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
| block.c | diffblobblamehistory | |
| block/mirror.c | diffblobblamehistory | |
| blockdev.c | diffblobblamehistory | |
| include/block/block.h | diffblobblamehistory | |
| include/block/block_int.h | diffblobblamehistory |