| commit | 5ca0e6fec591fd07add84f1f28b5c95a494b8401 | |
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Thu, 5 Mar 2020 16:09:14 +0000 (5 16:09 +0000) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Thu, 5 Mar 2020 16:09:14 +0000 (5 16:09 +0000) | ||
| tree | 89f9431435c44f3ef3f2dec6a30ddb0263a8582e | treesnapshot (tar.gz zip) |
| parent | a2d3b8f24c53b3c7d4cf07cb92b2db42abf804d0 | commitdiff |
hw/arm/smmu-common: Simplify smmu_find_smmu_pcibus() logic
The smmu_find_smmu_pcibus() function was introduced (in commit
cac994ef43b) in a code format that could return an incorrect
pointer, which was then fixed by the previous commit.
We could have avoided this by writing the if() statement
differently. Do it now, in case this function is re-used.
The code is easier to review (harder to miss bugs).
Acked-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
The smmu_find_smmu_pcibus() function was introduced (in commit
cac994ef43b) in a code format that could return an incorrect
pointer, which was then fixed by the previous commit.
We could have avoided this by writing the if() statement
differently. Do it now, in case this function is re-used.
The code is easier to review (harder to miss bugs).
Acked-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| hw/arm/smmu-common.c | diffblobblamehistory |