| commit | 5c96e091e8fb2bb7809bb1bfcd1dc1e954627292 | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Tue, 19 Dec 2017 04:45:19 +0000 (19 15:45 +1100) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Thu, 21 Dec 2017 00:16:47 +0000 (21 02:16 +0200) | ||
| tree | 3d59b080f8a2205b42cb4d2a48e5565b333804e0 | treesnapshot (tar.gz zip) |
| parent | 8fc47c876de638353bb635872f2c25bb7f4a3d6e | commitdiff |
tests/pxe-test: Remove unnecessary special case test functions
All of the x86 and some of the other test cases here use a common test
function, test_pxe_ipv4(), but one ppc and one s390 test use different
functions.
In the s390 case, this is completely pointless, the right parameter to
test_pxe_ipv4() will already do exactly the right thing. For the
spapr-vlan case there's a slight difference - it will use IPv6 instead of
IPv4.
But testing just one case with IPv6 (and NOT IPv4) is rather haphazard.
Change everything to use the common test function, until we have a better
way of testing IPv6 across the board.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
All of the x86 and some of the other test cases here use a common test
function, test_pxe_ipv4(), but one ppc and one s390 test use different
functions.
In the s390 case, this is completely pointless, the right parameter to
test_pxe_ipv4() will already do exactly the right thing. For the
spapr-vlan case there's a slight difference - it will use IPv6 instead of
IPv4.
But testing just one case with IPv6 (and NOT IPv4) is rather haphazard.
Change everything to use the common test function, until we have a better
way of testing IPv6 across the board.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| tests/pxe-test.c | diffblobblamehistory |