| commit | 5b7b2a1cf979a6754fd425431e2ca19208c72918 | |
| author | Thomas Huth <thuth@redhat.com> | |
| Fri, 17 Mar 2023 13:57:37 +0000 (17 14:57 +0100) | ||
| committer | Thomas Huth <thuth@redhat.com> | |
| Mon, 20 Mar 2023 11:43:43 +0000 (20 12:43 +0100) | ||
| tree | da47d109851d199db0054d5164119939a41e40e8 | treesnapshot (tar.gz zip) |
| parent | e902126caea1695aa89da97ef5804a9131224313 | commitdiff |
target/s390x/tcg/mem_helper: Remove bad assert() statement
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised the
exception directly). I would think we could just remove the assert."
Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230317135737.597570-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised the
exception directly). I would think we could just remove the assert."
Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230317135737.597570-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| target/s390x/tcg/mem_helper.c | diffblobblamehistory |