| commit | 5ad81b4946baf948c65cf7e1436d9b74803c1280 | |
| author | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 15 Feb 2019 15:53:51 +0000 (15 16:53 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Mon, 25 Feb 2019 14:03:19 +0000 (25 15:03 +0100) | ||
| tree | f6f97765e84155fd31281f60ecdd42bf0f37b187 | treesnapshot (tar.gz zip) |
| parent | 680f200217748e0920b79ec1d524717c2f50935b | commitdiff |
nbd: Restrict connection_co reentrance
nbd_client_attach_aio_context() schedules connection_co in the new
AioContext and this way reenters it in any arbitrary place that has
yielded. We can restrict this a bit to the function call where the
coroutine actually sits waiting when it's idle.
This doesn't solve any bug yet, but it shows where in the code we need
to support this random reentrance and where we don't have to care.
Add FIXME comments for the existing bugs that the rest of this series
will fix.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
nbd_client_attach_aio_context() schedules connection_co in the new
AioContext and this way reenters it in any arbitrary place that has
yielded. We can restrict this a bit to the function call where the
coroutine actually sits waiting when it's idle.
This doesn't solve any bug yet, but it shows where in the code we need
to support this random reentrance and where we don't have to care.
Add FIXME comments for the existing bugs that the rest of this series
will fix.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
| block/nbd-client.c | diffblobblamehistory | |
| block/nbd-client.h | diffblobblamehistory |