hw/display/qxl: Suppress clang-7 warning about misaligned atomic operation
commit5a358b39f52a28a84b380c1685c93010987b3412
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 27 Sep 2018 15:55:38 +0000 (27 16:55 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 5 Oct 2018 09:21:17 +0000 (5 11:21 +0200)
tree5b9ed345f8a88f4a61dc91fbb35c509528b48c8d
parent1242429b20ddcd7f1ad046ac8750c486938f2cbb
hw/display/qxl: Suppress clang-7 warning about misaligned atomic operation

If QEMU is compiled with clang-7 it results in the warning:

hw/display/qxl.c:1884:19: error: misaligned or large atomic operation
may incur significant performance penalty [-Werror,-Watomic-alignment]
    old_pending = atomic_fetch_or(&d->ram->int_pending, le_events);
                  ^

This is because the Spice headers forgot to define the QXLRam struct
with the '__aligned__(4)' attribute.  clang 7 and newer will thus
warn that the access here to int_pending might not be 4-aligned
(because the QXLRam object d->ram points at might start at a
misaligned address).  In fact we set up d->ram in init_qxl_ram() so
it always starts at a 4K boundary, so we know the atomic access here
is OK.

Newer Spice versions (with Spice commit
beda5ec7a6848be20c0cac2a9a8ef2a41e8069c1) will fix the bug;
for older Spice versions, work around it by telling the compiler
explicitly that the alignment is OK using __builtin_assume_aligned().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180927155538.699-1-peter.maydell@linaro.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/display/qxl.c
include/qemu/compiler.h