qcow2: introduce compression type feature
commit572ad9783f3e728a70617ce6bf144c09de3add50
authorDenis Plotnikov <dplotnikov@virtuozzo.com>
Thu, 7 May 2020 08:25:18 +0000 (7 11:25 +0300)
committerMax Reitz <mreitz@redhat.com>
Wed, 13 May 2020 12:20:31 +0000 (13 14:20 +0200)
tree74fc24fcf09d7ed4acdf55949fa52b2d45726469
parentd5c75ec500d96f1d93447f990cd5a4ef5ba27fae
qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.

It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus compression type
defines the only compression algorithm used for the image, and thus,
for all image clusters.

The goal of the feature is to add support of other compression methods
to qcow2. For example, ZSTD which is more effective on compression than ZLIB.

The default compression is ZLIB. Images created with ZLIB compression type
are backward compatible with older qemu versions.

Adding of the compression type breaks a number of tests because now the
compression type is reported on image creation and there are some changes
in the qcow2 header in size and offsets.

The tests are fixed in the following ways:
    * filter out compression_type for many tests
    * fix header size, feature table size and backing file offset
      affected tests: 031, 036, 061, 080
      header_size +=8: 1 byte compression type
                       7 bytes padding
      feature_table += 48: incompatible feature compression type
      backing_file_offset += 56 (8 + 48 -> header_change + feature_table_change)
    * add "compression type" for test output matching when it isn't filtered
      affected tests: 049, 060, 061, 065, 082, 085, 144, 182, 185, 198, 206,
                      242, 255, 274, 280

Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
QAPI part:
Acked-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200507082521.29210-2-dplotnikov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
23 files changed:
block/qcow2.c
block/qcow2.h
include/block/block_int.h
qapi/block-core.json
tests/qemu-iotests/031.out
tests/qemu-iotests/036.out
tests/qemu-iotests/049.out
tests/qemu-iotests/060.out
tests/qemu-iotests/061.out
tests/qemu-iotests/065
tests/qemu-iotests/080
tests/qemu-iotests/082.out
tests/qemu-iotests/085.out
tests/qemu-iotests/144.out
tests/qemu-iotests/182.out
tests/qemu-iotests/185.out
tests/qemu-iotests/198.out
tests/qemu-iotests/206.out
tests/qemu-iotests/242.out
tests/qemu-iotests/255.out
tests/qemu-iotests/274.out
tests/qemu-iotests/280.out
tests/qemu-iotests/common.filter