| commit | 55281a2c53b884d0c2bce31aee592faf20a28eed | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Thu, 13 Dec 2018 12:02:52 +0000 (13 12:02 +0000) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Thu, 20 Dec 2018 16:07:24 +0000 (20 17:07 +0100) | ||
| tree | 4b7886dd04456b95c83ef1ebeefd501aff6ba094 | treesnapshot (tar.gz zip) |
| parent | b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429 | commitdiff |
hw/s390/ccw.c: Don't take address of packed members
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this.
Avoid the problem by using local copies of the PMCW and SCSW
struct fields in copy_schib_from_guest() and copy_schib_to_guest().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20181213120252.21697-1-peter.maydell@linaro.org>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this.
Avoid the problem by using local copies of the PMCW and SCSW
struct fields in copy_schib_from_guest() and copy_schib_to_guest().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20181213120252.21697-1-peter.maydell@linaro.org>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| hw/s390x/css.c | diffblobblamehistory |