| commit | 53645dc4cb7b74db3507558c01612c3e5ea430ab | |
| author | Richard Henderson <richard.henderson@linaro.org> | |
| Mon, 12 Jul 2021 18:39:06 +0000 (12 18:39 +0000) | ||
| committer | Richard Henderson <richard.henderson@linaro.org> | |
| Mon, 26 Jul 2021 17:06:49 +0000 (26 07:06 -1000) | ||
| tree | abbdb773a64edd890fc35bb3378bacda178cce48 | treesnapshot (tar.gz zip) |
| parent | 2521c775bdfc8150396c4cb173b54d51f44c207e | commitdiff |
util/selfmap: Discard mapping on error
From clang-13:
util/selfmap.c:26:21: error: variable 'errors' set but not used \
[-Werror,-Wunused-but-set-variable]
Quite right of course, but there's no reason not to check errors.
First, incrementing errors is incorrect, because qemu_strtoul
returns an errno not a count -- just or them together so that
we have a non-zero value at the end.
Second, if we have an error, do not add the struct to the list,
but free it instead.
Cc: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
From clang-13:
util/selfmap.c:26:21: error: variable 'errors' set but not used \
[-Werror,-Wunused-but-set-variable]
Quite right of course, but there's no reason not to check errors.
First, incrementing errors is incorrect, because qemu_strtoul
returns an errno not a count -- just or them together so that
we have a non-zero value at the end.
Second, if we have an error, do not add the struct to the list,
but free it instead.
Cc: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| util/selfmap.c | diffblobblamehistory |