| commit | 532cee4184877053398a2bdae4edc965084fc79e | |
| author | Stefan Weil <sw@weilnetz.de> | |
| Sat, 7 Mar 2015 09:14:30 +0000 (7 10:14 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 10 Mar 2015 09:49:25 +0000 (10 10:49 +0100) | ||
| tree | 0d0420132f9255b7e4cbdb2c5153a7657bae8f03 | treesnapshot (tar.gz zip) |
| parent | 277263e1b320d759a760ba6c5ea75ec268f929e5 | commitdiff |
iscsi: Fix check for username
The variable user in struct iscsi_url is a character array, not a pointer.
Therefore its address will never be NULL.
clang reports this error:
block/iscsi.c:1329:20: warning:
comparison of array 'iscsi_url->user' not equal to a null pointer
is always true [-Wtautological-pointer-compare]
Reviewed-by: Peter Lieven <pl@kamp.de>
Acked-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <1425719670-5486-1-git-send-email-sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The variable user in struct iscsi_url is a character array, not a pointer.
Therefore its address will never be NULL.
clang reports this error:
block/iscsi.c:1329:20: warning:
comparison of array 'iscsi_url->user' not equal to a null pointer
is always true [-Wtautological-pointer-compare]
Reviewed-by: Peter Lieven <pl@kamp.de>
Acked-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <1425719670-5486-1-git-send-email-sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| block/iscsi.c | diffblobblamehistory |