hw/net: Avoid casting non-const pointer, use address_space_write()
commit4ef044cb148a5238161310f06bc581aeed70059f
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 20 Feb 2020 10:25:40 +0000 (20 11:25 +0100)
committerPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 20 Feb 2020 13:47:08 +0000 (20 14:47 +0100)
tree98bd540884f6640a2be5dcced871697e556b31a6
parentdaa3dda43af90d1c88d439891c6c7129959ccc77
hw/net: Avoid casting non-const pointer, use address_space_write()

The NetReceive prototype gets a const buffer:

  typedef ssize_t (NetReceive)(NetClientState *, const uint8_t *, size_t);

We already have the address_space_write() method to write a const
buffer to an address space. Use it to avoid:

  hw/net/i82596.c: In function ‘i82596_receive’:
  hw/net/i82596.c:644:54: error: passing argument 4 of ‘address_space_rw’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]

This commit was produced with the included Coccinelle script
scripts/coccinelle/exec_rw_const.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/net/dp8393x.c
hw/net/i82596.c
scripts/coccinelle/exec_rw_const.cocci