| commit | 4ded9bb54ceefeb68e766fe9aafc10de934c4501 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 6 Nov 2018 15:13:22 +0000 (6 15:13 +0000) | ||
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | |
| Sat, 10 Nov 2018 14:07:53 +0000 (10 15:07 +0100) | ||
| tree | 1dfac08e3ce18c48ea46626f3383f9212d9de0d7 | treesnapshot (tar.gz zip) |
| parent | 84ec9bfaf239b61bac3e43f708772937401e0e63 | commitdiff |
slirp: Remove code that handles socreate() failure
Now that socreate() can never fail, we can remove the code
that was trying to handle that situation.
In particular this removes code in tcp_connect() that
provoked Coverity to complain (CID 1005724): in
closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
if the accept() call fails then we pass closesocket() -1
instead of a valid file descriptor.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Now that socreate() can never fail, we can remove the code
that was trying to handle that situation.
In particular this removes code in tcp_connect() that
provoked Coverity to complain (CID 1005724): in
closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
if the accept() call fails then we pass closesocket() -1
instead of a valid file descriptor.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>