| commit | 4be56c19593c15bc8d16abcb63bfdd4697a5754d | |
| author | Greg Kurz <groug@kaod.org> | |
| Thu, 25 May 2017 08:30:13 +0000 (25 10:30 +0200) | ||
| committer | Greg Kurz <groug@kaod.org> | |
| Thu, 25 May 2017 08:30:13 +0000 (25 10:30 +0200) | ||
| tree | de1683a06b16b1757ab08304debfd1aab355c47b | treesnapshot (tar.gz zip) |
| parent | 6a87e7929f97b86c5823d4616fa1aa7636b2f116 | commitdiff |
fsdev: fix virtfs-proxy-helper cwd
Since chroot() doesn't change the current directory, it is indeed a good
practice to chdir() to the target directory and then then chroot(), or
to chroot() to the target directory and then chdir("/").
The current code does neither of them actually. Let's go for the latter.
This doesn't fix any security issue since all of this takes place before
the helper begins to process requests.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Since chroot() doesn't change the current directory, it is indeed a good
practice to chdir() to the target directory and then then chroot(), or
to chroot() to the target directory and then chdir("/").
The current code does neither of them actually. Let's go for the latter.
This doesn't fix any security issue since all of this takes place before
the helper begins to process requests.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
| fsdev/virtfs-proxy-helper.c | diffblobblamehistory |