| commit | 49aa4058ac6dd0081aaa45776f07c98df397ca5e | |
| author | Stefan Weil <sw@weilnetz.de> | |
| Mon, 30 Sep 2013 21:04:49 +0000 (30 23:04 +0200) | ||
| committer | Michael Tokarev <mjt@tls.msk.ru> | |
| Sat, 5 Oct 2013 09:05:15 +0000 (5 13:05 +0400) | ||
| tree | 810fdef3de54da503f6bd3207fc7728bb1724f8c | treesnapshot (tar.gz zip) |
| parent | 4b351a0f212769deda960da44e299f44d5da0737 | commitdiff |
qemu-char: Fix potential out of bounds access to local arrays
Latest gcc-4.8 supports a new option -fsanitize=address which activates
an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation
very early because two character arrays of size 8 are potentially written
with 9 bytes.
Commit 6ea314d91439741e95772dfbab98b4135e04bebb added the code.
There is no obvious reason why width or height could need 8 characters,
so reduce it to 7 characters which together with the terminating '\0'
fit into the arrays.
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Alex Bennée <alex@bennee.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Latest gcc-4.8 supports a new option -fsanitize=address which activates
an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation
very early because two character arrays of size 8 are potentially written
with 9 bytes.
Commit 6ea314d91439741e95772dfbab98b4135e04bebb added the code.
There is no obvious reason why width or height could need 8 characters,
so reduce it to 7 characters which together with the terminating '\0'
fit into the arrays.
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Alex Bennée <alex@bennee.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| qemu-char.c | diffblobblamehistory |