| commit | 46f296cd3a3ebc3d30e2dbc1da7c4882e3d35ce5 | |
| author | Daniel P. Berrange <berrange@redhat.com> | |
| Wed, 23 Dec 2015 13:59:04 +0000 (23 13:59 +0000) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Fri, 15 Jan 2016 17:58:01 +0000 (15 18:58 +0100) | ||
| tree | 9c834b82207256d09d1f2aa5d904b4d58d4a090c | treesnapshot (tar.gz zip) |
| parent | fca10318390dd3c2e9c9e90fbcdff0fe50188dbf | commitdiff |
qemu-char: delete send_all/recv_all helper methods
The qemu-char.c contains two helper methods send_all
and recv_all. These are in fact declared in sockets.h
so ought to have been in util/qemu-sockets.c. For added
fun the impl of recv_all is completely missing on Win32.
Fortunately there is only a single caller of these
methods, the TPM passthrough code, which is only
ever compiled on Linux. With only a single caller
these helpers are not compelling enough to keep so
inline them in the TPM code, avoiding the need to
fix the missing recv_all on Win32.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1450879144-17111-1-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The qemu-char.c contains two helper methods send_all
and recv_all. These are in fact declared in sockets.h
so ought to have been in util/qemu-sockets.c. For added
fun the impl of recv_all is completely missing on Win32.
Fortunately there is only a single caller of these
methods, the TPM passthrough code, which is only
ever compiled on Linux. With only a single caller
these helpers are not compelling enough to keep so
inline them in the TPM code, avoiding the need to
fix the missing recv_all on Win32.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1450879144-17111-1-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/tpm/tpm_passthrough.c | diffblobblamehistory | |
| include/qemu/sockets.h | diffblobblamehistory | |
| qemu-char.c | diffblobblamehistory |