| commit | 46a4e4e6085c1e5ae498e350009ff6d321d9ee67 | |
| author | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | |
| Tue, 29 Mar 2011 19:04:41 +0000 (29 20:04 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Thu, 7 Apr 2011 11:51:47 +0000 (7 13:51 +0200) | ||
| tree | 7fed98f269c27d26b150bf5576b86b513bb02af0 | treesnapshot (tar.gz zip) |
| parent | b8c6d0958943c96ca9401961a1200568c7ec0268 | commitdiff |
block: Do not cache device size for removable media
The block layer caches the device size to avoid doing lseek(fd, 0,
SEEK_END) every time this value is needed. For removable media the
device size becomes stale if a new medium is inserted. This patch
simply prevents device size caching for removable media.
A smarter solution is to update the cached device size when a new medium
is inserted. Given that there are currently bugs with CD-ROM media
change I do not want to implement that approach until we've gotten
things correct first.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
The block layer caches the device size to avoid doing lseek(fd, 0,
SEEK_END) every time this value is needed. For removable media the
device size becomes stale if a new medium is inserted. This patch
simply prevents device size caching for removable media.
A smarter solution is to update the cached device size when a new medium
is inserted. Given that there are currently bugs with CD-ROM media
change I do not want to implement that approach until we've gotten
things correct first.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| block.c | diffblobblamehistory |