vl.c/exit: pause cpus before closing block devices
commit452589b6b47e8dc6353df257fc803dfc1383bed8
authorDr. David Alan Gilbert <dgilbert@redhat.com>
Thu, 13 Jul 2017 19:01:16 +0000 (13 20:01 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 1 Aug 2017 15:27:33 +0000 (1 17:27 +0200)
tree49abe5a6e9ae40db18f5d32ee93b2be0803f272c
parent7d48cf8102a10e4a54333811bafb5eb566509268
vl.c/exit: pause cpus before closing block devices

There's a rare exit seg if the guest is accessing
IO during exit.
It's always hitting the atomic_inc(&bs->in_flight) with a NULL
bs. This was added recently in 99723548  but I don't see it
as the cause.

Flip vl.c around so we pause the cpus before closing the block devices,
that way we shouldn't have anything trying to access them when
they're gone.

This was originally Red Hat bz https://bugzilla.redhat.com/show_bug.cgi?id=1451015

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reported-by: Cong Li <coli@redhat.com>
--
This is a very rare race, I'll leave it running in a loop to see if
we hit anything else and to check this really fixes it.

I do worry if there are other cases that can trigger this - e.g.
hot-unplug or ejecting a CD.

Message-Id: <20170713190116.21608-1-dgilbert@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
vl.c