qom: Drop convenience method object_property_get_uint16List()
commit44a17fe05a363d0f94cd0706fbe64cb4524adf54
authorMarkus Armbruster <armbru@redhat.com>
Tue, 5 May 2020 15:29:13 +0000 (5 17:29 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 15 May 2020 04:26:02 +0000 (15 06:26 +0200)
treebea77e379bd3083b24fb5d983e83df8495e52cf0
parentb555f89fcbdc797423f6d6a41b76ef5fa5272235
qom: Drop convenience method object_property_get_uint16List()

qom/object.c provides object_property_get_TYPE() and
object_property_set_TYPE() for a number of common types.  These are
all convenience wrappers around object_property_get_qobject() and
object_property_set_qobject().

Except for object_property_get_uint16List(), which is unusual in two ways:

* It bypasses object_property_get_qobject().  Fixable; the previous
  commit did it for object_property_get_enum())

* It stores the value through a parameter.  Its contract claims it
  returns the value, like the other functions do.  Also fixable.

Fixing is not worthwhile, though: object_property_get_uint16List() has
seen exactly one user in six years.

Convert the lone user to do its job with the generic
object_property_get_qobject(), and drop object_property_get_uint16List().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505152926.18877-6-armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
[Commit message typo fixed]
hw/core/machine-qmp-cmds.c
include/qom/object.h
qom/object.c