| commit | 43b510113bb2c6393c98a31dae9b57022a9c5636 | |
| author | Eric Blake <eblake@redhat.com> | |
| Thu, 17 Jan 2019 19:36:44 +0000 (17 13:36 -0600) | ||
| committer | Eric Blake <eblake@redhat.com> | |
| Mon, 21 Jan 2019 21:49:51 +0000 (21 15:49 -0600) | ||
| tree | 652a6194aae4111fc432159691cfc315fb0acbbc | treesnapshot (tar.gz zip) |
| parent | 9d26dfcbab62746b3e66ec7784d75c13ff499669 | commitdiff |
qemu-nbd: Avoid strtol open-coding
Our copy-and-pasted open-coding of strtol handling forgot to
handle overflow conditions. Use qemu_strto*() instead.
In the case of --partition, since we insist on a user-supplied
partition to be non-zero, we can use 0 rather than -1 for our
initial value to distinguish when a partition is not being
served, for slightly more optimal code.
The error messages for out-of-bounds values are less specific,
but should not be a terrible loss in quality.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Message-Id: <20190117193658.16413-8-eblake@redhat.com>
Our copy-and-pasted open-coding of strtol handling forgot to
handle overflow conditions. Use qemu_strto*() instead.
In the case of --partition, since we insist on a user-supplied
partition to be non-zero, we can use 0 rather than -1 for our
initial value to distinguish when a partition is not being
served, for slightly more optimal code.
The error messages for out-of-bounds values are less specific,
but should not be a terrible loss in quality.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Message-Id: <20190117193658.16413-8-eblake@redhat.com>
| qemu-nbd.c | diffblobblamehistory |