jobs: remove ret argument to job_completed; privatize it
commit404ff28d6ae59fc1c24d631710d4063fc68aed03
authorJohn Snow <jsnow@redhat.com>
Thu, 30 Aug 2018 01:57:33 +0000 (29 21:57 -0400)
committerMax Reitz <mreitz@redhat.com>
Fri, 31 Aug 2018 14:28:33 +0000 (31 16:28 +0200)
tree3a3372e88ef7416810959e99d312d0ac7c6defbe
parent6870277535493fea31761d8d11ec23add2de0fb0
jobs: remove ret argument to job_completed; privatize it

Jobs are now expected to return their retcode on the stack, from the
.run callback, so we can remove that argument.

job_cancel does not need to set -ECANCELED because job_completed will
update the return code itself if the job was canceled.

While we're here, make job_completed static to job.c and remove it from
job.h; move the documentation of return code to the .run() callback and
to the job->ret property, accordingly.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20180830015734.19765-9-jsnow@redhat.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
include/qemu/job.h
job.c
trace-events