qapi: Improve reporting of missing / unknown definition keys
commit3f58cc29a8d2f01dc498ff4624a25e72448059a1
authorMarkus Armbruster <armbru@redhat.com>
Fri, 27 Sep 2019 13:46:33 +0000 (27 15:46 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Sat, 28 Sep 2019 15:17:19 +0000 (28 17:17 +0200)
tree39d5b75b46390d8009553c6962fe74d5eb6efa79
parenta6735a574382b214d7f1ee7b315cc81421aaa77e
qapi: Improve reporting of missing / unknown definition keys

Have check_exprs() call check_keys() later, so its error messages gain
an "in definition" line.

Both check_keys() and check_name_is_str() check the definition's name
is a string.  Since check_keys() now runs after check_name_is_str()
rather than before, its check is dead.  Bury it.  Checking values in
check_keys() is unclean anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-21-armbru@redhat.com>
scripts/qapi/common.py
tests/qapi-schema/alternate-base.err
tests/qapi-schema/bad-type-bool.err
tests/qapi-schema/bad-type-dict.err
tests/qapi-schema/double-type.err
tests/qapi-schema/enum-missing-data.err
tests/qapi-schema/unknown-expr-key.err