migration: mark mixed functions that can suspend
commit394b9407e4c515f96df6647d629ee28cbb86f07c
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 16 Dec 2022 11:48:16 +0000 (16 12:48 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 20 Apr 2023 09:17:35 +0000 (20 11:17 +0200)
tree586b944f5e1f8c339a2b3b735082fe5e28009ab5
parent1dd91b22a620616cad08bee7efc29280121ff0da
migration: mark mixed functions that can suspend

There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path.  By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn markers.  This results in more accurate checks that
coroutine code does not end up blocking.

If the marking were extended transitively to all functions that call
these ones, static analysis could be done much more efficiently.
However, this is a start and makes it possible to use vrc's path-based
searches to find potential bugs where coroutine_fns call blocking functions.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/migration/qemu-file-types.h
migration/qemu-file.c
migration/qemu-file.h