hw/arm/virt: Only try to add valid dynamic sysbus devices to platform bus
commit37fce4dde15f7f7891be89972629d96f851f9815
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 25 Mar 2021 15:33:09 +0000 (25 15:33 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 6 Apr 2021 10:49:14 +0000 (6 11:49 +0100)
treed93c49878ae54b4384cca5332549765f7b550082
parent0fb124dbfa135945fb892d0d2b7a427cdc59220d
hw/arm/virt: Only try to add valid dynamic sysbus devices to platform bus

The virt machine device plug callback currently calls
platform_bus_link_device() for any sysbus device.  This is overly
broad, because platform_bus_link_device() will unconditionally grab
the IRQs and MMIOs of the device it is passed, whether it was
intended for the platform bus or not.  Restrict hotpluggability of
sysbus devices to only those devices on the dynamic sysbus
allowlist.

We were mostly getting away with this because the board creates the
platform bus as the last device it creates, and so the hotplug
callback did not do anything for all the sysbus devices created by
the board itself.  However if the user plugged in a device which
itself uses a sysbus device internally we would have mishandled this
and probably asserted.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20210325153310.9131-4-peter.maydell@linaro.org
hw/arm/virt.c