net/dump: Improve -net/host_net_add dump error reporting
commit3791f83ca999edc2d11eb2006ccc1091cd712c15
authorMarkus Armbruster <armbru@redhat.com>
Fri, 15 May 2015 11:58:52 +0000 (15 13:58 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 27 May 2015 08:51:05 +0000 (27 09:51 +0100)
tree0fea3606998240a6595e9d6a2ce12067b54a8462
parent6630886863d4a9b3b7bcb3b0e2895d83eb269c75
net/dump: Improve -net/host_net_add dump error reporting

When -net dump fails, it first reports a specific error, then a
generic one, like this:

    $ qemu-system-x86_64 -net dump,id=foo,file=/eperm
    qemu-system-x86_64: -net dump,id=foo,file=/eperm: -net dump: can't open /eperm
    qemu-system-x86_64: -net dump,id=foo,file=/eperm: Device 'dump' could not be initialized

Convert net_init_tap() to Error.  This suppresses the unwanted second
message.

Improve the error messages to include strerror(errno) where
appropriate.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1431691143-1015-5-git-send-email-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
net/dump.c