| commit | 3549f8c9e4f0ef1c3417ff43b2164f68ad34b922 | |
| author | David Hildenbrand <david@redhat.com> | |
| Mon, 14 Jan 2019 10:31:08 +0000 (14 11:31 +0100) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Fri, 18 Jan 2019 10:52:01 +0000 (18 11:52 +0100) | ||
| tree | eb6a2ca2e3f68a2c1ca77cf543b060989381fba6 | treesnapshot (tar.gz zip) |
| parent | d648a3e62d5e726526f9df283341999792f4fbf9 | commitdiff |
s390x/pci: Ignore the unplug call if we already have a release_timer
... otherwise two successive calls to qdev_unplug() (e.g. by an impatient
user) will effectively overwrite pbdev->release_timer, resulting in a
memory leak. We are already processing the unplug.
If there is already a release_timer, the unplug will be performed after
the timeout.
Can be easily triggered by
(hmp) device_add virtio-mouse-pci,id=test
(hmp) stop
(hmp) device_del test
(hmp) device_del test
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190114103110.10909-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
... otherwise two successive calls to qdev_unplug() (e.g. by an impatient
user) will effectively overwrite pbdev->release_timer, resulting in a
memory leak. We are already processing the unplug.
If there is already a release_timer, the unplug will be performed after
the timeout.
Can be easily triggered by
(hmp) device_add virtio-mouse-pci,id=test
(hmp) stop
(hmp) device_del test
(hmp) device_del test
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190114103110.10909-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| hw/s390x/s390-pci-bus.c | diffblobblamehistory |