| commit | 350e7d9a77d3b9ac74d240e4b232db1ebe5c05bc | |
| author | Finn Thain <fthain@telegraphics.com.au> | |
| Wed, 29 Jan 2020 09:27:49 +0000 (29 20:27 +1100) | ||
| committer | Jason Wang <jasowang@redhat.com> | |
| Tue, 3 Mar 2020 10:04:47 +0000 (3 18:04 +0800) | ||
| tree | ce5513fd8a167f350f787279f52310ef9fe40d84 | treesnapshot (tar.gz zip) |
| parent | ea2270279bc2e1635cb6e909e22e17e630198773 | commitdiff |
dp8393x: Pad frames to word or long word boundary
The existing code has a bug where the Remaining Buffer Word Count (RBWC)
is calculated with a truncating division, which gives the wrong result
for odd-sized packets.
Section 1.4.1 of the datasheet says,
Once the end of the packet has been reached, the serializer will
fill out the last word (16-bit mode) or long word (32-bit mode)
if the last byte did not end on a word or long word boundary
respectively. The fill byte will be 0FFh.
Implement buffer padding so that buffer limits are correctly enforced.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
The existing code has a bug where the Remaining Buffer Word Count (RBWC)
is calculated with a truncating division, which gives the wrong result
for odd-sized packets.
Section 1.4.1 of the datasheet says,
Once the end of the packet has been reached, the serializer will
fill out the last word (16-bit mode) or long word (32-bit mode)
if the last byte did not end on a word or long word boundary
respectively. The fill byte will be 0FFh.
Implement buffer padding so that buffer limits are correctly enforced.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| hw/net/dp8393x.c | diffblobblamehistory |