| commit | 3110cdbd8a4845c5b5fb861b0a664c56d993dd3c | |
| author | David Hildenbrand <david@redhat.com> | |
| Wed, 20 Sep 2017 14:50:25 +0000 (20 16:50 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Thu, 21 Sep 2017 10:40:08 +0000 (21 12:40 +0200) | ||
| tree | a261c0dc5900362c5000beea1bbe97e3aa8cc4dc | treesnapshot (tar.gz zip) |
| parent | 55289fb036481396466d7825fa01d829c891108c | commitdiff |
kvm: drop wrong assertion creating problems with pflash
pflash toggles mr->romd_mode. So this assert does not always hold.
1) a device was added with !mr->romd_mode, therefore effectively not
creating a kvm slot as we want to trap every access (add = false).
2) mr->romd_mode was toggled on before remove it. There is now
actually no slot to remove and the assert is wrong.
So let's just drop the assert.
Reported-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170920145025.19403-1-david@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
pflash toggles mr->romd_mode. So this assert does not always hold.
1) a device was added with !mr->romd_mode, therefore effectively not
creating a kvm slot as we want to trap every access (add = false).
2) mr->romd_mode was toggled on before remove it. There is now
actually no slot to remove and the assert is wrong.
So let's just drop the assert.
Reported-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170920145025.19403-1-david@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| accel/kvm/kvm-all.c | diffblobblamehistory |