Revert "qdev: Free QemuOpts when the QOM path goes away"
commit2fc06c4ac65594ad248e9a9150ebdde9ff5a1253
authorMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 16 Oct 2017 22:23:14 +0000 (16 17:23 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 18 Oct 2017 08:34:50 +0000 (18 10:34 +0200)
tree792b9842201ca6e2475018d6621b9995ce06cc64
parent04162f8f4bcf8c9ae2422def4357289b44208c8c
Revert "qdev: Free QemuOpts when the QOM path goes away"

This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44.

This patch originally addressed an issue where a DEVICE_DELETED
event could be emitted (in device_unparent()) before a Device's
QemuOpts were cleaned up (in device_finalize()), leading to a
"duplicate ID" error if management attempted to immediately add
a device with the same ID in response to the DEVICE_DELETED event.

An alternative will be implemented in a subsequent patch where we
defer the DEVICE_DELETED event until device_finalize(), which would
also prevent the race, so we revert the original fix in preparation.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-3-mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/core/qdev.c