| commit | 2daa11912699d9412fb4404d646031a74b166aa5 | |
| author | Luiz Capitulino <lcapitulino@redhat.com> | |
| Mon, 14 Dec 2009 20:53:24 +0000 (14 18:53 -0200) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Fri, 18 Dec 2009 17:26:27 +0000 (18 11:26 -0600) | ||
| tree | 6094feb647f04bba7831d6006f70a0dfb2a9fa92 | treesnapshot (tar.gz zip) |
| parent | 183e6e525764d5c4978e37b42dc2cde0b0ffcfec | commitdiff |
monitor: Catch printing to non-existent monitor
The monitor_vprintf() function now touches the 'mon' pointer
before calling monitor_puts(), this causes block migration
to segfault as its functions call monitor_printf() with a
NULL 'mon'.
To fix the problem this commit moves the 'mon' NULL check
from monitor_puts() to monitor_vprintf().
This can potentially hide bugs, but for some reason this has
been the behavior for a long time.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
The monitor_vprintf() function now touches the 'mon' pointer
before calling monitor_puts(), this causes block migration
to segfault as its functions call monitor_printf() with a
NULL 'mon'.
To fix the problem this commit moves the 'mon' NULL check
from monitor_puts() to monitor_vprintf().
This can potentially hide bugs, but for some reason this has
been the behavior for a long time.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| monitor.c | diffblobblamehistory |