| commit | 2cbe2de5454cf9af44b620b2b40d56361a12a45f | |
| author | Fam Zheng <famz@redhat.com> | |
| Thu, 18 May 2017 10:28:08 +0000 (18 18:28 +0800) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 6 Jun 2017 18:18:36 +0000 (6 20:18 +0200) | ||
| tree | 8d44642008d1ac66abbf581c2918175ca2d8b905 | treesnapshot (tar.gz zip) |
| parent | 003a0cf2cd1828a1141a874428571267b117f765 | commitdiff |
virtio-scsi: Unset hotplug handler when unrealize
This matches the qbus_set_hotplug_handler in realize, and it releases
the final reference to the embedded VirtIODevice so that it is
properly finalized.
A use-after-free is fixed with this patch, indirectly:
virtio_device_instance_finalize wasn't called at hot-unplug, and the
vdev->listener would be a dangling pointer in the global and the per
address space listener list. See also RHBZ 1449031.
Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170518102808.30046-1-famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This matches the qbus_set_hotplug_handler in realize, and it releases
the final reference to the embedded VirtIODevice so that it is
properly finalized.
A use-after-free is fixed with this patch, indirectly:
virtio_device_instance_finalize wasn't called at hot-unplug, and the
vdev->listener would be a dangling pointer in the global and the per
address space listener list. See also RHBZ 1449031.
Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170518102808.30046-1-famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/scsi/virtio-scsi.c | diffblobblamehistory |