| commit | 292743d976324004d0c4f6f08e6d0589679d40ea | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 4 Dec 2019 09:36:16 +0000 (4 10:36 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Wed, 18 Dec 2019 07:36:15 +0000 (18 08:36 +0100) | ||
| tree | a3ceb72c7518e57c7ac32dd9e95f07dcd119eb44 | treesnapshot (tar.gz zip) |
| parent | f6166a4da59bdd57b3af8b1c742ce611d6c3d3aa | commitdiff |
qga: Fix guest-get-fsinfo error API violations
build_guest_fsinfo_for_virtual_device() dereferences @errp when
build_guest_fsinfo_for_device() fails. That's wrong; see the big
comment in error.h. Introduced in commit 46d4c5723e "qga: Add
guest-get-fsinfo command".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20191204093625.14836-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
build_guest_fsinfo_for_virtual_device() dereferences @errp when
build_guest_fsinfo_for_device() fails. That's wrong; see the big
comment in error.h. Introduced in commit 46d4c5723e "qga: Add
guest-get-fsinfo command".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20191204093625.14836-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
| qga/commands-posix.c | diffblobblamehistory |