hw/isa/isa-superio: Fix IDE controller realization
commit28b18db754da45d978b0a65f9aa4afbc82edb925
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Tue, 21 Jul 2020 12:45:16 +0000 (21 14:45 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Tue, 1 Sep 2020 07:02:37 +0000 (1 09:02 +0200)
tree6c2cc5ef8168ca958ff3671daba14cb6f736782c
parentb22c2a68c7d5a57175f13c5920a20e8297955e9b
hw/isa/isa-superio: Fix IDE controller realization

When realizing a Super I/O with IDE controller [*], we get:

  qom/object.c:1684: object_property_try_add_child: Assertion `!child->parent' failed.
  Aborted (core dumped)

This is because the device is already realized when we try to
add the QOM property to the parent. Fix by realizing *after*
adding the QOM relationship.

[*] Set ISASuperIOClass::ide.count = N with N not zero
    (no such thing currently exists; the bug is latent)

Fixes: e508430619 ("hw/isa/superio: Make the components QOM children")
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200721124516.9602-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/isa/isa-superio.c