vmdk: false positive of compat6 with hwversion not set
commit26c9296c31bc5d0fab24379af0a1684b099067de
authoryuchenlin <yuchenlin@synology.com>
Thu, 21 Feb 2019 11:08:05 +0000 (21 11:08 +0000)
committerMax Reitz <mreitz@redhat.com>
Mon, 25 Feb 2019 14:11:28 +0000 (25 15:11 +0100)
tree3a2e0776369063febff896e6b35c7fcae8645ee5
parent0482098608b83b559bc1802e4c612051b51f6c4c
vmdk: false positive of compat6 with hwversion not set

In vmdk_co_create_opts, when it finds hw_version is undefined, it will
set it to 4, which misleading the compat6 and hwversion in
vmdk_co_do_create. Simply set hw_version to NULL after free, let
the logic in vmdk_co_do_create to decide the value of hw_version.

This bug can be reproduced by:

$ qemu-img convert -O vmdk -o subformat=streamOptimized,compat6
/home/yuchenlin/syno.qcow2 /home/yuchenlin/syno.vmdk

qemu-img: /home/yuchenlin/syno.vmdk: error while converting vmdk:
compat6 cannot be enabled with hwversion set

Signed-off-by: yuchenlin <yuchenlin@synology.com>
Message-id: 20190221110805.28239-1-yuchenlin@synology.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/vmdk.c