| commit | 269ee27e99cfbff983a9ab067ae22f6182f11fe2 | |
| author | Eric Blake <eblake@redhat.com> | |
| Thu, 7 Feb 2019 19:13:57 +0000 (7 13:13 -0600) | ||
| committer | Eric Blake <eblake@redhat.com> | |
| Mon, 11 Feb 2019 20:35:43 +0000 (11 14:35 -0600) | ||
| tree | 717d684ce2b2d3cecb1cd27fb866feef0b641a96 | treesnapshot (tar.gz zip) |
| parent | 22c5f446514a2a4bb0dbe1fea26713da92fc85fa | commitdiff |
nbd/server: Kill pointless shadowed variable
lgtm.com pointed out that commit 678ba275 introduced a shadowed
declaration of local variable 'bs'; thankfully, the inner 'bs'
obtained by 'blk_bs(blk)' matches the outer one given that we had
'blk_insert_bs(blk, bs, errp)' a few lines earlier, and there are
no later uses of 'bs' beyond the scope of the 'if (bitmap)' to
care if we change the value stored in 'bs' while traveling the
backing chain to find a bitmap. So simply get rid of the extra
declaration.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190207191357.6665-1-eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
lgtm.com pointed out that commit 678ba275 introduced a shadowed
declaration of local variable 'bs'; thankfully, the inner 'bs'
obtained by 'blk_bs(blk)' matches the outer one given that we had
'blk_insert_bs(blk, bs, errp)' a few lines earlier, and there are
no later uses of 'bs' beyond the scope of the 'if (bitmap)' to
care if we change the value stored in 'bs' while traveling the
backing chain to find a bitmap. So simply get rid of the extra
declaration.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190207191357.6665-1-eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
| nbd/server.c | diffblobblamehistory |