| commit | 2658594ff64828bf4230d9224b394034dae14028 | |
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Thu, 11 Jul 2019 12:52:46 +0000 (11 14:52 +0200) | ||
| committer | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Tue, 16 Jul 2019 15:54:06 +0000 (16 17:54 +0200) | ||
| tree | 1b4f116d4a5ca39a879ad204c8de6ac45b560579 | treesnapshot (tar.gz zip) |
| parent | 697f59243f5a28b8a243ff5ad59e34bbecffcae1 | commitdiff |
hw/block/pflash_cfi02: Explicit switch fallthrough for ERASE commands
Previous to commit ddb6f2254, the DQ2 bit was incorrectly set
during PROGRAM command (0xA0). The commit reordered the switch
cases to only set the DQ2 bit for the ERASE commands using a
fallthrough, but did not explicit the fallthrough is intentional.
Mark the switch fallthrough with a comment interpretable by C
preprocessors and static analysis tools.
Reported-by: Coverity (CID 1403012)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20190711130759.27720-1-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Previous to commit ddb6f2254, the DQ2 bit was incorrectly set
during PROGRAM command (0xA0). The commit reordered the switch
cases to only set the DQ2 bit for the ERASE commands using a
fallthrough, but did not explicit the fallthrough is intentional.
Mark the switch fallthrough with a comment interpretable by C
preprocessors and static analysis tools.
Reported-by: Coverity (CID 1403012)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20190711130759.27720-1-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| hw/block/pflash_cfi02.c | diffblobblamehistory |