| commit | 2594f56d4c7ef621da5d0c21921f8fda32025623 | |
| author | Daniel P. Berrange <berrange@redhat.com> | |
| Wed, 27 Apr 2016 10:05:14 +0000 (27 11:05 +0100) | ||
| committer | Amit Shah <amit.shah@redhat.com> | |
| Thu, 26 May 2016 06:02:07 +0000 (26 11:32 +0530) | ||
| tree | 2c687eecbd4e6e8186f90a92206f40bb1c005bb2 | treesnapshot (tar.gz zip) |
| parent | a24939f2791d930f109ddb2658147aa4eae40361 | commitdiff |
migration: don't use an array for storing migrate parameters
The MigrateState struct uses an array for storing migration
parameters. This presumes that all future parameters will
be integers too, which is not going to be the case. There
is no functional reason why an array is used, if anything
it makes the code less clear. The QAPI schema already
defines a struct - MigrationParameters - capable of storing
all the individual parameters, so just use that instead of
an array.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1461751518-12128-25-git-send-email-berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
The MigrateState struct uses an array for storing migration
parameters. This presumes that all future parameters will
be integers too, which is not going to be the case. There
is no functional reason why an array is used, if anything
it makes the code less clear. The QAPI schema already
defines a struct - MigrationParameters - capable of storing
all the individual parameters, so just use that instead of
an array.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1461751518-12128-25-git-send-email-berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
| include/migration/migration.h | diffblobblamehistory | |
| migration/migration.c | diffblobblamehistory | |
| migration/ram.c | diffblobblamehistory |