| commit | 25145a7d7735344a469551946fc2a7f19eb4aa3d | |
| author | Pavel Pisa <pisa@cmp.felk.cvut.cz> | |
| Wed, 3 Jan 2024 23:14:26 +0000 (4 00:14 +0100) | ||
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | |
| Fri, 5 Jan 2024 15:20:15 +0000 (5 16:20 +0100) | ||
| tree | f0590ad2ff0f405d65509df61956af8a13b60bdd | treesnapshot (tar.gz zip) |
| parent | 5e077a77670d36975cc0dc885d2e9d9f67ab14c1 | commitdiff |
hw/net/can/sja1000: fix bug for single acceptance filter and standard frame
A CAN sja1000 standard frame filter mask has been computed and applied
incorrectly for standard frames when single Acceptance Filter Mode
(MOD_AFM = 1) has been selected. The problem has not been found
by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0)
and leaves falters fully open.
The problem has been noticed by Grant Ramsay when testing with Zephyr
RTOS which uses single filter mode.
Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Reported-by: Grant Ramsay <gramsay@enphaseenergy.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2028
Fixes: 733210e754 ("hw/net/can: SJA1000 chip register level emulation")
Message-ID: <20240103231426.5685-1-pisa@fel.cvut.cz>
A CAN sja1000 standard frame filter mask has been computed and applied
incorrectly for standard frames when single Acceptance Filter Mode
(MOD_AFM = 1) has been selected. The problem has not been found
by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0)
and leaves falters fully open.
The problem has been noticed by Grant Ramsay when testing with Zephyr
RTOS which uses single filter mode.
Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Reported-by: Grant Ramsay <gramsay@enphaseenergy.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2028
Fixes: 733210e754 ("hw/net/can: SJA1000 chip register level emulation")
Message-ID: <20240103231426.5685-1-pisa@fel.cvut.cz>
| hw/net/can/can_sja1000.c | diffblobblamehistory |