| commit | 248e3ffb66c27cf95623f965b61b0eb97a607441 | |
| author | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 14 Feb 2020 20:08:06 +0000 (14 21:08 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Tue, 18 Feb 2020 09:53:56 +0000 (18 10:53 +0100) | ||
| tree | 05933130d510345a4ecb4aff54ad7a047da9df07 | treesnapshot (tar.gz zip) |
| parent | 5b1405db0fbe4c2600dbaa1a340110a3aecef173 | commitdiff |
qapi: Document meaning of 'ignore' BlockdevOnError for jobs
It is not obvious what 'ignore' actually means for block jobs: It could
be continuing the job and returning success in the end despite the error
(no block job does this). It could also mean continuing and returning
failure in the end (this is what stream does). And it can mean retrying
the failed request later (this is what backup, commit and mirror do).
This (somewhat inconsistent) behaviour was introduced and described for
stream and mirror in commit 32c81a4a6ec. backup and commit were
introduced later and use the same model as mirror.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200214200812.28180-2-kwolf@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
It is not obvious what 'ignore' actually means for block jobs: It could
be continuing the job and returning success in the end despite the error
(no block job does this). It could also mean continuing and returning
failure in the end (this is what stream does). And it can mean retrying
the failed request later (this is what backup, commit and mirror do).
This (somewhat inconsistent) behaviour was introduced and described for
stream and mirror in commit 32c81a4a6ec. backup and commit were
introduced later and use the same model as mirror.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200214200812.28180-2-kwolf@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| qapi/block-core.json | diffblobblamehistory |