| commit | 22956a3755749b9cf6375ad024d58c1d277100bf | |
| author | Alexey Kardashevskiy <aik@ozlabs.ru> | |
| Wed, 5 Mar 2014 05:15:16 +0000 (5 16:15 +1100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Fri, 14 Mar 2014 09:06:55 +0000 (14 10:06 +0100) | ||
| tree | b857aa946fd5de51475222671a909e4efd52bb12 | treesnapshot (tar.gz zip) |
| parent | 5d92c74f8a1728a202ba9457872ab0f27ff15e81 | commitdiff |
spapr-vscsi: fix CRQ status
Normally VIOSRP_OK (0) means success and non-zero value means error
except VIOSRP_OK2 (0x99) which is another success code by weird accident.
This uses 0 as success code always as some guests do not cope with
the 0x99 value well. The existing linux driver checks for both VIOSRP_OK
and VIOSRP_OK2 since 2.6.32.
This returns non-zero code (VIOSRP_ADAPTER_FAIL == 0x10) on errors which
can only happen if DMA write failed.
Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Normally VIOSRP_OK (0) means success and non-zero value means error
except VIOSRP_OK2 (0x99) which is another success code by weird accident.
This uses 0 as success code always as some guests do not cope with
the 0x99 value well. The existing linux driver checks for both VIOSRP_OK
and VIOSRP_OK2 since 2.6.32.
This returns non-zero code (VIOSRP_ADAPTER_FAIL == 0x10) on errors which
can only happen if DMA write failed.
Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/scsi/spapr_vscsi.c | diffblobblamehistory |