Mostly revert "qemu-help: Sort devices by logical functionality"
commit1fc224b4b6d195fb7802d5ba1a0846a4e7a1e2af
authorMarkus Armbruster <armbru@redhat.com>
Thu, 10 Oct 2013 13:00:20 +0000 (10 15:00 +0200)
committerAnthony Liguori <aliguori@amazon.com>
Fri, 11 Oct 2013 16:36:29 +0000 (11 09:36 -0700)
tree53c1eff702898a2f2009d840f51b04c10f8ca1d7
parent859389810910f232188675d2f10b15f1aad77660
Mostly revert "qemu-help: Sort devices by logical functionality"

This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5.

The commit claims to sort the output of "-device help" "by
functionality rather than alphabetical".  Issues:

* The output was unsorted before, not alphabetically sorted.
  Misleading, but harmless enough.

* The commit doesn't just sort the output of "-device help" as it
  claims, it adds categories to each line of "-device help", and it
  prints devices once per category.  In particular, devices without a
  category aren't shown anymore.  Maybe such devices should not exist,
  but they do.  Regression.

* Categories are also added to the output of "info qdm".  Silent
  change, not nice.  Output remains unsorted, unlike "-device help".

I'm going to reimplement the feature we actually want, without the
warts.  Reverting the flawed commit first should make it easier to
review.  However, I can't revert it completely, since DeviceClass
member categories has been put to use.  So leave that part in.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Message-id: 1381410021-1538-2-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@amazon.com>
include/hw/qdev-core.h
qdev-monitor.c