monitor: use aio_co_reschedule_self()
commit1f25c172f83704e350c0829438d832384084a74d
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 6 Feb 2024 19:06:10 +0000 (6 14:06 -0500)
committerKevin Wolf <kwolf@redhat.com>
Wed, 7 Feb 2024 13:44:21 +0000 (7 14:44 +0100)
tree4fa82d83400f8fe6a367bbf580048fe250794a3f
parent8802f4f4e3a3e7e0ffc778cab853b14349574a7b
monitor: use aio_co_reschedule_self()

The aio_co_reschedule_self() API is designed to avoid the race
condition between scheduling the coroutine in another AioContext and
yielding.

The QMP dispatch code uses the open-coded version that appears
susceptible to the race condition at first glance:

  aio_co_schedule(qemu_get_aio_context(), qemu_coroutine_self());
  qemu_coroutine_yield();

The code is actually safe because the iohandler and qemu_aio_context
AioContext run under the Big QEMU Lock. Nevertheless, set a good example
and use aio_co_reschedule_self() so it's obvious that there is no race.

Suggested-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240206190610.107963-6-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qapi/qmp-dispatch.c