virtio-blk: Remove useless condition around g_free()
commit1d29b5b0499c4d1f0415fadf94e41ed8964a7ed3
authorFam Zheng <famz@redhat.com>
Tue, 7 Feb 2017 13:27:22 +0000 (7 21:27 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 10 May 2017 07:19:23 +0000 (10 10:19 +0300)
tree8223092376446419c42d1b647575d5e9fa6183d8
parent3ba34a70223a78e89094c7f0a2f7cb6a667b8f9e
virtio-blk: Remove useless condition around g_free()

Laszlo spotted and studied this wasteful "if". He pointed out:

The original virtio_blk_free_request needed an "if" as it accesses one
field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to
pointer", 2014-06-11); later on in f897bf751fbd ("virtio-blk: embed
VirtQueueElement in VirtIOBlockReq", 2014-07-09) the field became
embedded, so the "if" became unnecessary (at which point we were using
g_slice_free(), but it is the same.

Now drop it.

Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/block/virtio-blk.c