| commit | 1bce6b4ce3ba03015bdf16d40c1bbe33d8b6031b | |
| author | Eric Blake <eblake@redhat.com> | |
| Sat, 29 Apr 2017 19:14:11 +0000 (29 14:14 -0500) | ||
| committer | Max Reitz <mreitz@redhat.com> | |
| Thu, 11 May 2017 12:28:05 +0000 (11 14:28 +0200) | ||
| tree | 8db89eb24641d01b5a32c8af9456f929fcbfbdd2 | treesnapshot (tar.gz zip) |
| parent | 698bdfa07d66b5ec218a60229e58eae1dcde00e5 | commitdiff |
qemu-io: Improve alignment checks
Several copy-and-pasted alignment checks exist in qemu-io, which
could use some minor improvements:
- Manual comparison against 0x1ff is not as clean as using our
alignment macros (QEMU_IS_ALIGNED) from osdep.h.
- The error messages aren't quite grammatically correct.
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Suggested-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 20170429191419.30051-2-eblake@redhat.com
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Several copy-and-pasted alignment checks exist in qemu-io, which
could use some minor improvements:
- Manual comparison against 0x1ff is not as clean as using our
alignment macros (QEMU_IS_ALIGNED) from osdep.h.
- The error messages aren't quite grammatically correct.
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Suggested-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 20170429191419.30051-2-eblake@redhat.com
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
| qemu-io-cmds.c | diffblobblamehistory |