| commit | 1bbd6272a18d6fe3390d4b4200a1a7a566b304fa | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Thu, 1 Nov 2018 16:17:58 +0000 (1 16:17 +0000) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Thu, 8 Nov 2018 01:04:40 +0000 (8 12:04 +1100) | ||
| tree | ded6627f955e446eb099282e2969ca06c3406322 | treesnapshot (tar.gz zip) |
| parent | 0c2adc175398c37cc40b0164849aada9ad9c56c4 | commitdiff |
hw/ppc/mac_newworld: Free openpic_irqs array after use
In ppc_core99_init(), we allocate an openpic_irqs array, which
we then use to collect up the various qemu_irqs which we're
going to connect to the interrupt controller. Once we've
called sysbus_connect_irq() to connect them all up, the
array is no longer required, but we forgot to free it.
Since board init is only run once at startup, the memory
leak is not a significant one.
Spotted by Coverity: CID 1192916.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
In ppc_core99_init(), we allocate an openpic_irqs array, which
we then use to collect up the various qemu_irqs which we're
going to connect to the interrupt controller. Once we've
called sysbus_connect_irq() to connect them all up, the
array is no longer required, but we forgot to free it.
Since board init is only run once at startup, the memory
leak is not a significant one.
Spotted by Coverity: CID 1192916.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/mac_newworld.c | diffblobblamehistory |