configure: Fix shell syntax to placate OpenBSD's pdksh
commit18f49881cf8359e89396aac12f5d3cf3f8a632ba
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 14 Dec 2015 15:02:36 +0000 (14 15:02 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 18 Dec 2015 13:32:49 +0000 (18 13:32 +0000)
treebafdf27aa19fa0810e6124f766a838ec4823fc6c
parent67a708406221f476c0f8fa60c192c186150c5185
configure: Fix shell syntax to placate OpenBSD's pdksh

Unfortunately the OpenBSD pdksh does not like brackets inside
the right part of a ${variable+word} parameter expansion:

  $ echo "${a+($b)}"
  ksh: ${a+($b)}": bad substitution

though both bash and dash accept them. In any case this line
was causing odd output in the case where nettle is not present:
  nettle    no ()

(because if nettle is not present then $nettle will be "no",
not a null string or unset).

Rewrite it to just use an if.

This bug was originally introduced in becaeb726 and was present
in the 2.4.0 release.

Fixes: https://bugs.launchpad.net/qemu/+bug/1525682
Reported-by: Dmitrij D. Czarkoff
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1450105357-8516-1-git-send-email-peter.maydell@linaro.org
configure