| commit | 1259f27ec2113d34e54ee731aac5990d9606d9fa | |
| author | Daniel P. Berrangé <berrange@redhat.com> | |
| Mon, 15 Apr 2019 15:45:03 +0000 (15 16:45 +0100) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Thu, 2 May 2019 06:29:33 +0000 (2 08:29 +0200) | ||
| tree | cf27e55f405061bd6d17a7b1ba8bb6e5adb8ac29 | treesnapshot (tar.gz zip) |
| parent | 3541cd48f32233dd0c0766a3f342e3fd64b04381 | commitdiff |
usb-mtp: fix alignment of access of ObjectInfo filename field
The ObjectInfo struct's "filename" field is following a uint8_t
field in a packed struct and thus has bad alignment for a 16-bit
field. Switch the field to to uint8_t and use the helper function
for accessing unaligned 16-bit data.
Note that although the MTP spec specifies big endian, when transported
over the USB protocol, data is little endian.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20190415154503.6758-4-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
The ObjectInfo struct's "filename" field is following a uint8_t
field in a packed struct and thus has bad alignment for a 16-bit
field. Switch the field to to uint8_t and use the helper function
for accessing unaligned 16-bit data.
Note that although the MTP spec specifies big endian, when transported
over the USB protocol, data is little endian.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20190415154503.6758-4-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| hw/usb/dev-mtp.c | diffblobblamehistory |